feat(core): Add option to support chip variants #12036
Merged
+179
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
added
Status: Review needed
Contributor
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
* add `chip_variant` to pioarduino-build.py to support different variants of an MCU (p4 prev3 and postv3) * Refactor build_mcu and chip_variant assignment logic * ci(pre-commit): Apply automatic fixes * Fix chip_variant retrieval with default value --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
4 tasks
lucasssvaz
approved these changes
Nov 17, 2025
P-R-O-C-H-Y
reviewed
Nov 18, 2025
Member
Author
|
@P-R-O-C-H-Y also removed the CPU freq selection menu, because it makes no sense anymore |
Contributor
Test Results 76 files 76 suites 19m 29s ⏱️ Results for commit a1bc749. ♻️ This comment has been updated with latest results. |
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for selecting and building against different ESP32P4 chip variants, improving flexibility for board configuration and toolchain compatibility. The changes primarily add a new "Chip Variant" menu option, update build variables to use the selected chip variant, and ensure the correct SDK paths are used during compilation.
Board configuration enhancements:
Chip Variantmenu option inboards.txtto allow users to select between different chip variants for ESP32P4 boards.prev3andpostv3) for ESP32P4, with corresponding build flags and CPU frequencies.Build system updates:
esp32p4.build.chip_variantvariable inboards.txtfor more precise board configuration.platform.txtto use{build.chip_variant}instead of{build.mcu}for SDK paths, ensuring the correct libraries are used for each variant.build.chip_variant={build.mcu}toplatform.txtto propagate the chip variant setting through the build process.Depends on espressif/esp32-arduino-lib-builder#333